From: Nikolay Sivov Subject: urlmon: Remove duplicated check (PVS-Studio) Message-Id: <53EFAAD5.8060502@codeweavers.com> Date: Sat, 16 Aug 2014 23:02:45 +0400 str_len is checked earlier using same condition From 3481e1e8701b758bff7cc165ed0cc777fdd8ac5e Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sat, 16 Aug 2014 14:00:21 +0400 Subject: [PATCH 11/11] urlmon: Remove duplicated check (PVS-Studio) --- dlls/urlmon/sec_mgr.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/urlmon/sec_mgr.c b/dlls/urlmon/sec_mgr.c index 5c145ae..e1c7ec8 100644 --- a/dlls/urlmon/sec_mgr.c +++ b/dlls/urlmon/sec_mgr.c @@ -241,11 +241,9 @@ static BOOL matches_domain_pattern(LPCWSTR pattern, LPCWSTR str, BOOL implicit_w * * Doesn't match the pattern. */ - if(str_len > pattern_len) { - if(str[str_len-pattern_len-1] == '.' && !strcmpiW(str+(str_len-pattern_len), pattern)) { - matches = TRUE; - *matched = str+(str_len-pattern_len); - } + if(str[str_len-pattern_len-1] == '.' && !strcmpiW(str+(str_len-pattern_len), pattern)) { + matches = TRUE; + *matched = str+(str_len-pattern_len); } } else { /* The pattern doesn't have an implicit wildcard, or an explicit wildcard, -- 2.0.1