From: Nikolay Sivov Subject: mshtml: Free buffer for empty strings too (PVS-Studio) Message-Id: <53EFAA91.20408@codeweavers.com> Date: Sat, 16 Aug 2014 23:01:37 +0400 --- From 99fe061cafa33458c921191c44a9958a64951035 Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sat, 16 Aug 2014 13:53:13 +0400 Subject: [PATCH 10/11] mshtml: Free buffer for empty strings too (PVS-Studio) --- dlls/mshtml/oleobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/oleobj.c b/dlls/mshtml/oleobj.c index ea8cea6..ca01288 100644 --- a/dlls/mshtml/oleobj.c +++ b/dlls/mshtml/oleobj.c @@ -375,7 +375,7 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, IOleClientSite (void**)&uihandler2); if(SUCCEEDED(hres)) { hres = IDocHostUIHandler2_GetOverrideKeyPath(uihandler2, &override_key_path, 0); - if(hres == S_OK && override_key_path && override_key_path[0]) { + if(hres == S_OK && override_key_path) { if(override_key_path[0]) { /*FIXME: use override_key_path */ FIXME("override_key_path = %s\n", debugstr_w(override_key_path)); -- 2.0.1